QGIS Auth db import by gabriel-bolbotina · Pull Request #4249 · MerginMaps/mobile

gabriel-bolbotina · 2025-12-12T07:46:52Z

Ready for review.
Added Auth sync class that handles the importation of authentication database configuration file.

tomasMizera

The exercise with the new AuthSync class is now feeling a bit too much - it's basically just calling the import method 🙃 I suggest we get rid of it altogether. In addition to that, the PR:

is missing autotests
missed project reload in case the auth file is changed
missed to reset auth entries before loading the auth db

Good job with the ossl linking fix.

app/authsync.cpp

tomasMizera · 2025-12-12T08:28:01Z

core/merginapi.cpp

  ProjectDiff diff = transaction.diff;
  int newVersion = syncSuccessful ? transaction.version : -1;

+  // TODO check if the xml configuration has been changed


I tried to only modify the xml configuration file from QGIS. Upon syncing, it was already detected by that function, which emitted a force reload of the project. So I don't think we should specifically check for the cfg modification at all.

Check this video.

app/activeproject.cpp

app/authsync.h

app/authsync.cpp

app/CMakeLists.txt

app/activeproject.cpp

app/main.cpp

app/test/testauthimport.cpp

app/test/testauthimport.h

app/test/testauthimport.cpp

app/activeproject.cpp

app/test/testactiveproject.cpp

Withalion · 2025-12-18T13:10:53Z

Some ideas for testing:

test opening project without qgis auth db exported and private layer (opening the project should succeed, but layer should be available)
test opening project with qgis auth db ( opening the project should succeed and layer should be available)
test synchronizing project should trigger reload of auth db

github-actions · 2025-12-18T16:21:27Z

Pull Request Test Coverage Report for Build 21666284673

Details

0 of 0 changed or added relevant lines in 0 files are covered.
163 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 59.707%

Files with Coverage Reduction	New Missed Lines	%
mm/core/merginapi.cpp	3	75.29%
mm/app/activeproject.cpp	71	70.74%
mm/app/main.cpp	89	36.5%

Totals
Change from base Build 21428698414:	0.2%
Covered Lines:	8639
Relevant Lines:	14469

💛 - Coveralls

Withalion · 2025-12-30T10:38:28Z

Windows build is failing because of the QCA_OSSL_PLUGIN lookup

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
QCA_OSSL_PLUGIN_LIB
    linked by target "MerginMaps" in directory D:/a/mobile/mobile/mm/app

github-actions · 2026-01-22T13:56:48Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 62251 dmg	Expires: 22/04/2026	#6225
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 54181 win64	Expires: 22/04/2026	#5418
Android Build	📬	Mergin Maps 753551 APK [arm64-v8a]	Expires: 22/04/2026	#7535
Android Build	📬	Mergin Maps 753511 APK [armeabi-v7a]	Expires: 22/04/2026	#7535
iOS Build	📬		Build number: 26.01.847611	#8476

github-actions · 2026-01-23T14:56:10Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 62261 dmg	Expires: 23/04/2026	#6226
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 54191 win64	Expires: 23/04/2026	#5419
Android Build	📬	Mergin Maps 753611 APK [armeabi-v7a]	Expires: 23/04/2026	#7536
Android Build	📬	Mergin Maps 753651 APK [arm64-v8a]	Expires: 23/04/2026	#7536
iOS Build	📬		Build number: 26.01.847711	#8477

Withalion

The loading of QGIS auth DB didn't work on Windows. Same project worked on Android.

app/activeproject.cpp

app/main.cpp

app/static_plugins.cpp

app/test/testactiveproject.h

app/CMakeLists.txt

Changed logic in auth sync

Added unit tests to handle the import of configuration file

This reverts commit 0595bee.

Added solution for QCA Windows build

formatted code

github-actions · 2026-01-29T07:59:46Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 62391 dmg	Expires: 29/04/2026	#6239
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 54321 win64	Expires: 29/04/2026	#5432
Android Build	📬	Mergin Maps 754951 APK [arm64-v8a]	Expires: 29/04/2026	#7549
Android Build	📬	Mergin Maps 754911 APK [armeabi-v7a]	Expires: 29/04/2026	#7549
iOS Build	📬		Build number: 26.01.849011	#8490

Upgraded qca version for windows functionality Removed unnecessary lines of code in main

gabriel-bolbotina · 2026-01-30T13:08:28Z

I upgraded the QCA version, and the authentication worked on Windows as well.

github-actions · 2026-01-30T13:34:45Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📭	Build not yet complete or failed.
linux Build	📬	Mergin Maps 62621 x86_64	Expires: 30/04/2026	#6262
win64 Build	📬	Mergin Maps 54441 win64	Expires: 30/04/2026	#5444
Android Build	📭	Build not yet complete or failed.
iOS Build	📭	Build not yet complete or failed.

tomasMizera

Looks good. Please adjust the unit test so that it includes at least one happy-case scenario though - success import of auth data, but not directly via auth manager API (like now), rather through activeProject.load() so it tests your new code.

app/test/testactiveproject.cpp

app/activeproject.cpp

CMakeLists.txt

Withalion · 2026-01-30T22:27:42Z

Off topic: We should try to build the app with cmake 4.0+ now, last time QCA was the thing not letting us build it

gabriel-bolbotina · 2026-02-02T07:09:59Z

Off topic: We should try to build the app with cmake 4.0+ now, last time QCA was the thing not letting us build it

I think you could create a ticket for it to be in the backlog 😉

github-actions · 2026-02-02T08:03:46Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📭	Build not yet complete or failed.
linux Build	📬	Mergin Maps 62671 x86_64	Expires: 03/05/2026	#6267
win64 Build	📬	Mergin Maps 54491 win64	Expires: 03/05/2026	#5449
Android Build	📭	Build not yet complete or failed.
iOS Build	📬		Build number: 26.02.850711	#8507

github-actions · 2026-02-04T10:02:57Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📭	Build not yet complete or failed.
linux Build	📬	Mergin Maps 62851 x86_64	Expires: 05/05/2026	#6285
win64 Build	📬	Mergin Maps 54671 win64	Expires: 05/05/2026	#5467
Android Build	📬	Mergin Maps 758411 APK [armeabi-v7a]	Expires: 05/05/2026	#7584
Android Build	📬	Mergin Maps 758451 APK [arm64-v8a]	Expires: 05/05/2026	#7584
iOS Build	📬		Build number: 26.02.852511	#8525

tomasMizera · 2026-02-04T11:30:56Z

app/main.cpp

+  // set up the master password for authentication database retrieval
  authManager->setPasswordHelperEnabled( false );
-  authManager->setMasterPassword( QStringLiteral( "merginMaps" ) );
+  authManager->setMasterPassword( QStringLiteral( "merginMaps" ), true );


The addition of verify=true does not seem to do much as we do not read the return value. Still ok though..

gabriel-bolbotina requested review from Withalion and tomasMizera December 12, 2025 07:46

tomasMizera requested changes Dec 12, 2025

View reviewed changes

tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Dec 15, 2025

gabriel-bolbotina force-pushed the feature/qgis-auth-db-sync branch from 8c4755a to 2281cca Compare December 15, 2025 13:32

gabriel-bolbotina requested a review from tomasMizera December 15, 2025 13:37

gabriel-bolbotina self-assigned this Dec 16, 2025

Withalion linked an issue Dec 17, 2025 that may be closed by this pull request

Add support to import QGIS auth DB from file #3534

Open

Withalion removed the FROZEN 🥶 do not merge before upcoming release label Dec 18, 2025

Withalion reviewed Dec 18, 2025

View reviewed changes

gabriel-bolbotina requested a review from Withalion January 26, 2026 10:13

Withalion reviewed Jan 28, 2026

View reviewed changes

app/activeproject.cpp Outdated Show resolved Hide resolved

app/main.cpp Outdated Show resolved Hide resolved

app/static_plugins.cpp Outdated Show resolved Hide resolved

app/test/testactiveproject.h Outdated Show resolved Hide resolved

Withalion reviewed Jan 28, 2026

View reviewed changes

app/CMakeLists.txt Outdated Show resolved Hide resolved

gabriel-bolbotina added 11 commits January 29, 2026 09:33

Added initial draft for the auth db sync

5bc1e59

Modified authsync

50354d6

Formatted code

c251edd

Simplified class

0caf555

Formatted code

5d5f9ad

Qca-workaround

9d1cc77

Modified auth db sync

651b714

Changed logic in auth sync

Formatted cmake file

34e5521

Implemented code review findings

e0ca6f2

Removed authSync class + header

6c424a1

Added unit tests to handle the import of configuration file

Modified mock cfg file, corrected test auth import

f05ee2f

gabriel-bolbotina and others added 9 commits January 29, 2026 09:33

Revert "Modified mock cfg file, corrected test auth import"

bdf48b4

This reverts commit 0595bee.

Implemented code review findings

7eb22b2

Implemented code findings

05ebb9b

Updated unit test

83470ec

Added solution for QCA Windows build

Modified cmake for windows qca

962ad45

Used windows dll

1fdd8f3

Fix QCA for windows build

e1a2031

Excluded opensslPlugin from the windows build

5608f8f

formatted code

Modified active project

fe5119e

gabriel-bolbotina force-pushed the feature/qgis-auth-db-sync branch from 9697596 to fe5119e Compare January 29, 2026 07:34

Updated comments

f0b9dec

Upgraded qca version for windows functionality Removed unnecessary lines of code in main

tomasMizera approved these changes Jan 30, 2026

View reviewed changes

app/test/testactiveproject.cpp Outdated Show resolved Hide resolved

app/activeproject.cpp Outdated Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

Implemented code findings

f848d4a

Fixed authentication database logic

d71664f

gabriel-bolbotina requested a review from tomasMizera February 4, 2026 10:15

tomasMizera approved these changes Feb 4, 2026

View reviewed changes

Conversation

gabriel-bolbotina commented Dec 12, 2025

Uh oh!

tomasMizera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tomasMizera Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

gabriel-bolbotina Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gabriel-bolbotina Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Withalion commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21666284673

Details

💛 - Coveralls

Uh oh!

Withalion commented Dec 30, 2025

Uh oh!

github-actions bot commented Jan 22, 2026

📦 Build Artifacts Ready

Uh oh!

github-actions bot commented Jan 23, 2026

📦 Build Artifacts Ready

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 29, 2026

📦 Build Artifacts Ready

Uh oh!

gabriel-bolbotina commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

📦 Build Artifacts Ready

Uh oh!

tomasMizera left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Withalion commented Jan 30, 2026

Uh oh!

gabriel-bolbotina commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026

📦 Build Artifacts Ready

Uh oh!

github-actions bot commented Feb 4, 2026

gabriel-bolbotina Dec 12, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

tomasMizera left a comment •

edited

Loading